Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ses): L2 EventDestination construct does not support Firehose or EventBridge destinations #32835

Closed
1 of 2 tasks
alexbaileyuk opened this issue Jan 10, 2025 · 2 comments · Fixed by #33093
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@alexbaileyuk
Copy link

Describe the feature

Reviewing the L1 documentation for AWS::SES::ConfigurationSetEventDestination shows that the available integration options are CWL, Firehose, Event Bridge and SNS. Docs: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ses.CfnConfigurationSetEventDestination.EventDestinationProperty.html#eventbridgedestination

However, only SNS is supported by the L2 abstraction of the EventDestination class. Docs: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ses.EventDestination.html

Use Case

SNS isn't a great integration option for these events. For example, using Event Bridge is a very cheap way to stream them through Lambda functions and perform actions based on events. Using Firehose is a really cheap way to populate a data lake of the events for future analytics.

Proposed Solution

Implement the above features in the L2 abstraction.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.175.0

Environment details (OS name and version, etc.)

Windows 11 - Node 22.11.0

@alexbaileyuk alexbaileyuk added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 10, 2025
@github-actions github-actions bot added the @aws-cdk/aws-ses Related to Amazon Simple Email Service label Jan 10, 2025
@ashishdhingra ashishdhingra self-assigned this Jan 10, 2025
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 10, 2025
@ashishdhingra
Copy link
Contributor

@alexbaileyuk Goor morning. Thanks for opening the feature request. This is perhaps a duplicate issue of #30671 for Firehose EventDestination. Feel free to contribute PR, mentioning the other related issue as well.

@ashishdhingra ashishdhingra added effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jan 10, 2025
@ashishdhingra ashishdhingra removed their assignment Jan 10, 2025
@mergify mergify bot closed this as completed in #33093 Feb 19, 2025
mergify bot pushed a commit that referenced this issue Feb 19, 2025
… destination (#33093)

### Issue # (if applicable)

Closes #32835
Closes #30671

### Reason for this change
ConfigurationSet doesn't support EventBridge, Firehose as destination

### Description of changes
ConfigurationSet destination support:
- Firehose
- default EventBus

<img width="912" alt="Screenshot 2025-01-23 192024" src="https://github.com/user-attachments/assets/d0e5ee91-ccb4-4cba-89e9-2ac94510536d" />

### Description of how you validated changes
Unit + integration

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
yashkh-amzn pushed a commit to yashkh-amzn/aws-cdk that referenced this issue Feb 21, 2025
… destination (aws#33093)

### Issue # (if applicable)

Closes aws#32835
Closes aws#30671

### Reason for this change
ConfigurationSet doesn't support EventBridge, Firehose as destination

### Description of changes
ConfigurationSet destination support:
- Firehose
- default EventBus

<img width="912" alt="Screenshot 2025-01-23 192024" src="https://github.com/user-attachments/assets/d0e5ee91-ccb4-4cba-89e9-2ac94510536d" />

### Description of how you validated changes
Unit + integration

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants