Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertions for AwsCustomResource integ tests (1/2) #29937

Closed
8 tasks done
colifran opened this issue Apr 23, 2024 · 2 comments · Fixed by #29929 or #29950
Closed
8 tasks done

Assertions for AwsCustomResource integ tests (1/2) #29937

colifran opened this issue Apr 23, 2024 · 2 comments · Fixed by #29929 or #29950
Assignees
@colifran

Comments

@colifran
Copy link
Contributor

colifran commented Apr 23, 2024 •
edited
Loading

Context

The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK. As a result, the SDK v2 handler used by AwsCustomResource is being removed. Several integ tests are impacted due to the changing asset hash and it was noted that none of these integ tests have assertions related to AwsCustomResource. To improve testing coverage we will be adding assertions to these integ tests.

Task Description

Update integ tests impacted by the removal of the SDK v2 handler to include assertions for AwsCustomResource where possible. Note that in some cases an assertion is not possible. For example, where the AwsCustomResource is making a describe related API call there will be nothing to assert against.

Acceptance Criteria

Investigate the following integ tests and add assertions where possible:

  • @aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2/test/integ.alb.oidc.ts
  • @aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.ts
  • @aws-cdk-testing/framework-integ/test/aws-elasticsearch/test/integ.elasticsearch.custom-kms-key.ts
  • @aws-cdk-testing/framework-integ/test/aws-elasticsearch/test/integ.elasticsearch.unsignedbasicauth.ts
  • @aws-cdk-testing/framework-integ/test/aws-events-targets/test/logs/integ.log-group.ts
  • @aws-cdk-testing/framework-integ/test/aws-globalaccelerator-endpoints/test/integ.globalaccelerator.ts
  • @aws-cdk-testing/framework-integ/test/aws-logs-destinations/test/integ.lambda.ts
  • @aws-cdk-testing/framework-integ/test/aws-opensearchservice/test/integ.opensearch.custom-kms-key.ts
@colifran colifran mentioned this issue Apr 23, 2024
Merged
1 task
@colifran colifran changed the title Assertions for AwsCustomResource integ tests Assertions for AwsCustomResource integ tests (1/2) Apr 23, 2024
@mergify mergify bot closed this as completed in #29929 Apr 23, 2024
mergify bot pushed a commit that referenced this issue Apr 23, 2024
@colifran
chore: add assertions to integ tests using AwsCustomResource (#29929)
1bdd3fa 
Closes #29937 

### Reason for this change

Adding assertions for `AwsCustomResource` will improve our test coverage.

### Description of changes

Added assertions for `AwsCustomResource` to integ tests that were impacted by this [PR](#29868).

### Description of how you validated changes

Assertions were validated by running the integ tests and verifying that it succeeded.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@SankyRed SankyRed mentioned this issue Apr 24, 2024
Merged
1 task
mergify bot pushed a commit that referenced this issue Apr 25, 2024
@SankyRed
chore: add assertions to integ tests using AwsCustomResource (#29950)
536d8ff 
Closes #29937 

### Reason for this change

Adding assertions for `AwsCustomResource` will improve our test coverage.

### Description of changes

Added assertions for `AwsCustomResource` to integ tests that were impacted by this [PR](#29868).

### Description of how you validated changes

Assertions were validated by running the integ tests and verifying that it succeeded.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Apr 26, 2024
Closed
Closed
Closed
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@colifran colifran

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aws-cdk-automation @SankyRed @colifran