Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-kinesisfirehose-alpha: Needs support for ca-west-1 #29874

Closed
parvahuja opened this issue Apr 17, 2024 · 2 comments · Fixed by #31206
Closed

aws-kinesisfirehose-alpha: Needs support for ca-west-1 #29874

parvahuja opened this issue Apr 17, 2024 · 2 comments · Fixed by #31206
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@parvahuja
Copy link

parvahuja commented Apr 17, 2024 •
edited
Loading

Describe the bug

Creating a DeliveryStream in ca-west-1 fails at synth time with Error: Mapping doesn't contain top-level key ca-west-1

Expected Behavior

Configured constructs in a stack set to deploy to ca-west-1 using aws-cdk-lib 2.134 and @aws-cdk/aws-kinesisfirehose-alpha 2.134-alpha. Expected a clean compile.

Current Behavior

Error: Mapping doesn't contain top-level key 'ca-west-1'
...

when attempting to compile.

Reproduction Steps

Just take any normal code example of DeliveryStream like your unit tests and synth it in ca-west-1.

Possible Solution

aws-kinesisfirehose-alpha uses a mapping of CIDR blocks (https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts#L768) per region. This list is incomplete (it does not include ca-west-1).

Additional Information/Context

Basically identical issue to #27518, but for another region and the (now) newest CDK

CDK CLI Version

2.134

Framework Version

No response

Node.js Version

v18.18.0

OS

Amazon Linux 2

Language

TypeScript

Language Version

TypeScript (4.9.4)

Other information

No response
@parvahuja parvahuja added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 17, 2024
@github-actions github-actions bot added the @aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose label Apr 17, 2024
@parvahuja parvahuja changed the title aws-kinesisfirehose-alpha: Needs support for ca-central-1 aws-kinesisfirehose-alpha: Needs support for ca-west-1 Apr 17, 2024
@khushail khushail self-assigned this Apr 17, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 17, 2024
@khushail
Copy link
Contributor

@parvahuja , thanks for reaching out. We have a similar issue filed with CDK Team internally, P125405005. Team is working on this.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Apr 17, 2024
@khushail khushail removed their assignment Apr 17, 2024
This was referenced Apr 22, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue May 1, 2024
Closed
@paulhcsun paulhcsun mentioned this issue Aug 23, 2024
Merged
1 task
@mergify mergify bot closed this as completed in #31206 Sep 4, 2024
mergify bot pushed a commit that referenced this issue Sep 4, 2024
@paulhcsun
chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block (#31206)
125ca2f 
### Issue # (if applicable)

Closes #29874

### Description of changes

Add missing CIDR block for `ca-west-1` + update snapshots. 

CIDRs pulled from [here](https://docs.aws.amazon.com/firehose/latest/dev/controlling-access.html#using-iam-rs).

### Description of how you validated changes

integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
pahud pushed a commit to pahud/aws-cdk that referenced this issue Sep 9, 2024
@paulhcsun @pahud
chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block (aws#…
c1a3dca 
…31206)

### Issue # (if applicable)

Closes aws#29874

### Description of changes

Add missing CIDR block for `ca-west-1` + update snapshots. 

CIDRs pulled from [here](https://docs.aws.amazon.com/firehose/latest/dev/controlling-access.html#using-iam-rs).

### Description of how you validated changes

integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao pushed a commit to xazhao/aws-cdk that referenced this issue Sep 12, 2024
@paulhcsun @xazhao
chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block (aws#…
a0f092b 
…31206)

### Issue # (if applicable)

Closes aws#29874

### Description of changes

Add missing CIDR block for `ca-west-1` + update snapshots. 

CIDRs pulled from [here](https://docs.aws.amazon.com/firehose/latest/dev/controlling-access.html#using-iam-rs).

### Description of how you validated changes

integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ pushed a commit that referenced this issue Sep 12, 2024
@paulhcsun @GavinZZ
chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block (#31206)
d34f2e0 
### Issue # (if applicable)

Closes #29874

### Description of changes

Add missing CIDR block for `ca-west-1` + update snapshots. 

CIDRs pulled from [here](https://docs.aws.amazon.com/firehose/latest/dev/controlling-access.html#using-iam-rs).

### Description of how you validated changes

integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block paulhcsun/aws-cdk
2 participants
@parvahuja @khushail