parseDeletionPolicy(module name): Reference based deletion policy #28292
Assignees
Labels
@aws-cdk/aws-iam
Related to AWS Identity and Access Management
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p1
Comments
|
Yea, we are using lpt-to-cdk in a Typescript CDK project. We have the template.yml defined like this in the build:
upon build, that error is generated given that a reference value is passed and not a string. |
|
I'm seeing the same error when I use an intrinsic function to provide a deletion policy, like this: This is valid according to the docs, but the CDK library can't parse it. The parsing code only understands null, undefined, or a string. |
|
mergify bot
pushed a commit
that referenced
this issue
Jan 24, 2024
> # Issue > > When using `CfnInclude` it was not possible to have an intrinsic function in the `DeletionPolicy`. It only allowed the DeletionPolicy to be explicitly defined. > # Solution > > Check if policy looks like an intrinsic. Check if it is an explicitly defined DeletionPolicy. Then Default to a case that checks if this is an intrinsic if it is return the policy after using parseValue. Else throw the same error it was previously. > # Important Design Decisions > > Unsure if any have been made please let me know if there are any I didn't think were Important Design Decisions. > > Remember to follow the [CONTRIBUTING GUIDE] and [DESIGN GUIDELINES] for any > code you submit. > > [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md > [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md Closes #28292 . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
penniman26
pushed a commit
to penniman26/aws-cdk
that referenced
this issue
Jan 25, 2024
> # Issue > > When using `CfnInclude` it was not possible to have an intrinsic function in the `DeletionPolicy`. It only allowed the DeletionPolicy to be explicitly defined. > # Solution > > Check if policy looks like an intrinsic. Check if it is an explicitly defined DeletionPolicy. Then Default to a case that checks if this is an intrinsic if it is return the policy after using parseValue. Else throw the same error it was previously. > # Important Design Decisions > > Unsure if any have been made please let me know if there are any I didn't think were Important Design Decisions. > > Remember to follow the [CONTRIBUTING GUIDE] and [DESIGN GUIDELINES] for any > code you submit. > > [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md > [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md Closes aws#28292 . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Vandita2020
pushed a commit
to Vandita2020/aws-cdk
that referenced
this issue
Jan 30, 2024
> # Issue > > When using `CfnInclude` it was not possible to have an intrinsic function in the `DeletionPolicy`. It only allowed the DeletionPolicy to be explicitly defined. > # Solution > > Check if policy looks like an intrinsic. Check if it is an explicitly defined DeletionPolicy. Then Default to a case that checks if this is an intrinsic if it is return the policy after using parseValue. Else throw the same error it was previously. > # Important Design Decisions > > Unsure if any have been made please let me know if there are any I didn't think were Important Design Decisions. > > Remember to follow the [CONTRIBUTING GUIDE] and [DESIGN GUIDELINES] for any > code you submit. > > [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md > [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md Closes aws#28292 . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
SankyRed
pushed a commit
that referenced
this issue
Feb 8, 2024
> # Issue > > When using `CfnInclude` it was not possible to have an intrinsic function in the `DeletionPolicy`. It only allowed the DeletionPolicy to be explicitly defined. > # Solution > > Check if policy looks like an intrinsic. Check if it is an explicitly defined DeletionPolicy. Then Default to a case that checks if this is an intrinsic if it is return the policy after using parseValue. Else throw the same error it was previously. > # Important Design Decisions > > Unsure if any have been made please let me know if there are any I didn't think were Important Design Decisions. > > Remember to follow the [CONTRIBUTING GUIDE] and [DESIGN GUIDELINES] for any > code you submit. > > [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md > [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md Closes #28292 . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
There is no ability to use reference based deletion policies in the code.
Expected Behavior
The code should be able to use the reference to the deletion policy.
Current Behavior
Error: Unrecognized DeletionPolicy '[object Object]' is what is output
Reproduction Steps
'DeletionPolicy':
'Default': 'RetainExceptOnCreate'
'Description': 'Default DeletionPolicy. This parameter sources from AWSWaypointPipelineDeployableCfn.'
'Type': 'String'
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.114.1
Framework Version
No response
Node.js Version
v21.3.0
OS
Ventura 13.5.1
Language
TypeScript
Language Version
TS 5.0.4
Other information
No response
The text was updated successfully, but these errors were encountered: