RDS: support passing PreferredMaintenanceWindow to Cluster database instances

[cpaton]

Description

When creating a DatabaseCluster it should be possible to specify PreferredMaintenanceWindow property for the database instances as per https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-rds-database-instance.html#cfn-rds-dbinstance-preferredmaintenancewindow

Use Case

Control maintenance window for database instances so maintenance is performed outside of production use hours e.g. minor version upgrades

Proposed Solution

Add preferredMaintenanceWindow property to InstanceProps when creating a DatabaseCluster. This value should be copied onto the underlying CfnDatabaseInstance object

Other information

No response

Acknowledge

• I may be able to implement this feature request
• This feature might incur a breaking change

[skinny85]

Thanks for opening the issue @cpaton. This should be a relatively simple feature to implement - it means adding the preferredMaintenanceWindow property to the InstanceProps interface, and then passing it here.

Would you consider opening us a PR adding this feature? Here's our "Contributing guide": https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md.

Thanks,
Adam

[github-actions]

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[ronocod]

If anyone else is running into this, you can synchronize the DBInstance maintenance windows with the DBCluster window using this:

function setInstanceMaintenanceWindows(cluster: rds.DatabaseCluster) {
  const clusterNode = cluster.node.children.find(
    (c) => c instanceof rds.CfnDBCluster
  ) as rds.CfnDBCluster;
  cluster.node.children.forEach((c) => {
    if (c instanceof rds.CfnDBInstance) {
      const temp = c;
      temp.preferredMaintenanceWindow = clusterNode.preferredMaintenanceWindow;
    }
  });
}

//  setInstanceMaintenanceWindows(this.cluster);

[keisukekomeda]

Can also use cdk.Aspects to set node property.

cdk.Aspects.of(cluster).add({
  visit: (node) => {
    if (node instanceof rds.CfnDBInstance) {
      node.addPropertyOverride(
        "PreferredMaintenanceWindow",
        "web:19:00-wed:19:30",
      );
    }
  },
});

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.