-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@aws-cdk/aws-apigatewayv2-integrations] support parameter mapping in Http Integrations #15293
Comments
@nija-at I might be able to implement this. Wanted to know if someone would be available to discuss design before I get started? |
Sure, it's here. Which refers to this page: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-parameter-mapping.html I have a proposal that is a bit different to what Novax proposed above. Can share its later tonight. |
Thanks @dan-lind. Sounds good. I would suggest that you start by opening a PR containing just the changes to the README of the Once we're happy there, you could then move to implementation. To keep the changes manageable, I recommend focusing on the experience of HTTP APIs without an integration subtype. |
@nija-at Was wondering if README changes shouldn't be in @aws-cdk/aws-apigatewayv2 rather than aws-apigatewayv2-integrations? Looks like all lower level stuff like this is kept in that main module. |
Perhaps. Where it goes would depend on your design. |
@dan-lind any idea when the Pull Request could be merged? It seems like the work is done here and only thing is missing is the merge itself. |
Don't know, it's waiting for a review from someone on the CDK team |
…eter mapping (#15630) ---- This is an initial PR as discussed with @nija-at in an attempt to describe the user experience for supporting parameter mapping. This PR will only support parameter mappings for HTTP APIs _without_ an integration subtypes, but it will provide interfaces that can (and probably should) be reused when adding support for integration subtypes as well. Since it also provides the possibility to provide custom key/value pairs for maximum flexibility, it can support and integration subtype although it requires a bit more work on the user side. closes #15293 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
…eter mapping (aws#15630) ---- This is an initial PR as discussed with @nija-at in an attempt to describe the user experience for supporting parameter mapping. This PR will only support parameter mappings for HTTP APIs _without_ an integration subtypes, but it will provide interfaces that can (and probably should) be reused when adding support for integration subtypes as well. Since it also provides the possibility to provide custom key/value pairs for maximum flexibility, it can support and integration subtype although it requires a bit more work on the user side. closes aws#15293 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I would like to have a possibility to configure parameter mapping to e.g. append or remove specific parameter in forwarded request.
Use Case
Currently there is no possibility to configure it, specifically in context of
HttpAlbIntegration
. These are only possible props:This functionality is available in AWS console and it's missing in aws cdk. It can be very helpful to e.g. pass some authorizer context parameters down to the backend.
Proposed Solution
It would be nice to have some additional field where proper mapping can be configured e.g.:
Same interface can be applied to rest of Integration classes.
Other
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: