-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(cli ls): building of Lambda layers is not disabled during "cdk ls" #14747
Comments
The Docker image will still be downloaded, but the building of the layer should no longer occur in the latest version of the CDK ( |
…o bundle assets (#16192) `DockerImage.fromBuild` was being called for bundling regardless of whether the stack needed bundling or not. With this change, we will check if the stack needs bundling before proceeding to build the docker image. Fixes #14747 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
…o bundle assets (aws#16192) `DockerImage.fromBuild` was being called for bundling regardless of whether the stack needed bundling or not. With this change, we will check if the stack needs bundling before proceeding to build the docker image. Fixes aws#14747 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Lambda functions bundling is disabled by default when running command such as
cdk ls
, but building of Lambda layers is not.This results in long delays until command returns desired output and output is populated by Docker build messages which makes it very hard to read. Also, Docker image needs to be downloaded when not locally available, which can extend command execution time to very long time.
Reproduction Steps
Run
cdk ls
with following code inapp.py
:What did you expect to happen?
I expect command to quickly return list of CDK stacks .
What actually happened?
CDK starts downloading Docker image it needs to build Lambda layer (executed only once) and builds the layer (executed always).
Command output is following:
Environment
Other
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: