Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DynamoDb]: Add support DynamoDb Contributer Insights #11626

Closed
pathik9 opened this issue Nov 23, 2020 · 7 comments · Fixed by #14742
Closed

[DynamoDb]: Add support DynamoDb Contributer Insights #11626

pathik9 opened this issue Nov 23, 2020 · 7 comments · Fixed by #14742
Assignees
@skinny85
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@pathik9
Copy link

pathik9 commented Nov 23, 2020

Currently there is no option to enable Contributer Insightes on DynamoDB table via Code (CDK). Please provide support for the same
@pathik9 pathik9 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 23, 2020
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Nov 23, 2020
@skinny85
Copy link
Contributor

skinny85 commented Dec 5, 2020

Hello @pathik9 ,

thanks for opening the issue. Is the ability to enable Contributor Insights on Dynamo DB available through CloudFormation currently?

Thanks,
Adam

@skinny85 skinny85 added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 5, 2020
@pathik9
Copy link
Author

pathik9 commented Dec 5, 2020 •
edited
Loading

Hi @skinny85

Dynamodb Contributor insights are not available via Cloudformation.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 5, 2020
@skinny85 skinny85 added the needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. label Dec 7, 2020
@skinny85
Copy link
Contributor

skinny85 commented Dec 7, 2020

Thanks @pathik9. That means we need to either wait for CloudFormation support before implementing this in CDK, or use a CFN Custom Resource. Since this seems like a small feature (a boolean flag I think?), a Custom Resource might be overkill (as it involves creating an additional Lambda function in your Stack).

Adding the needs-cfn label.

@jonny-rimek
Copy link

aws-cloudformation/cloudformation-coverage-roadmap#708

this is the issue to track it in the dynamodb repo

@jonny-rimek
Copy link

@skinny85 @pathik9 cfn support was added on the 22/2 =)

@skinny85
Copy link
Contributor

skinny85 commented Mar 2, 2021

It's here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dynamodb-table.html#cfn-dynamodb-table-contributorinsightsspecification

Looks like a pretty small boolean flag. Contributions are very welcome! 😊.

@skinny85 skinny85 added effort/small Small work item – less than a day of effort p2 and removed needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. needs-triage This issue or PR still needs to be triaged. labels Mar 2, 2021
@sudo-ryan sudo-ryan mentioned this issue May 18, 2021
Merged
@mergify mergify bot closed this as completed in #14742 May 19, 2021
mergify bot pushed a commit that referenced this issue May 19, 2021
@sudo-ryan
feat(dynamodb): add ability to enable contributor insights on Table (#…
3c7a89d 
…14742)

Resolve #11626

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@arnab arnab mentioned this issue Jun 11, 2021
Open
2 tasks
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@sudo-ryan @hollanddd
feat(dynamodb): add ability to enable contributor insights on Table (a…
e073353 
…ws#14742)

Resolve aws#11626

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dynamodb): add ability to enable contributor insights on Table
3 participants
@skinny85 @jonny-rimek @pathik9