Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloudwatch] Support adding metrics to GraphWidget after creation #11305

Closed
1 of 2 tasks
hoegertn opened this issue Nov 5, 2020 · 2 comments · Fixed by #11380
Closed
1 of 2 tasks

[cloudwatch] Support adding metrics to GraphWidget after creation #11305

hoegertn opened this issue Nov 5, 2020 · 2 comments · Fixed by #11380
Assignees
@rix0rrr
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2

Comments

@hoegertn
Copy link
Contributor

hoegertn commented Nov 5, 2020

Use Case

I would love to be able to add metrics to the left and right arrays after the widget object is created. This way I could create a widget object and pass it around and let other constructs add themselves to this widget.

Proposed Solution

Create an addMetric method to the GraphWidget. As it is lazily evaluated in the toJson() method it should not be a problem to do this.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@hoegertn hoegertn added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 5, 2020
@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Nov 5, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 9, 2020

Sounds good.

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 labels Nov 9, 2020
@hoegertn hoegertn mentioned this issue Nov 9, 2020
Merged
@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2020
@mergify mergify bot closed this as completed in #11380 Nov 10, 2020
mergify bot pushed a commit that referenced this issue Nov 10, 2020
@hoegertn
feat(cloudwatch): add methods for lazy addition of graph metrics (#11380
55e9576 
)

Resolves #11305 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@Cameronsplaze Cameronsplaze mentioned this issue Sep 10, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudwatch): add methods for lazy addition of graph metrics
3 participants
@rix0rrr @hoegertn @SomayaB