Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-stepfunctions-tasks: Athena missing .sync option #11246

Closed
nakedible-p opened this issue Nov 2, 2020 · 1 comment · Fixed by #11188
Closed

aws-stepfunctions-tasks: Athena missing .sync option #11246

nakedible-p opened this issue Nov 2, 2020 · 1 comment · Fixed by #11188
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@nakedible-p
Copy link
Contributor

nakedible-p commented Nov 2, 2020 •
edited
Loading

Just recently, support was added for AWS Athena to Step Functions, and subsequently support was also added to AWS CDK for that. In Step Functions, StartQueryExecution (and only that) supports also executing the query as a job and not request/response. However, in CDK, this does not seem to be the case:

https://github.com/aws/aws-cdk/blob/v1.71.0/packages/@aws-cdk/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts#L55-L58

Documentation on Step Functions Athena:

https://docs.aws.amazon.com/step-functions/latest/dg/connect-athena.html

Reproduction Steps

new sfn_tasks.AthenaStartQueryExecution(this, 'step', {
  integrationPattern: sfn.IntegrationPattern.RUN_JOB,
  queryString: `SELECT 1;`
});

What did you expect to happen?

The call to succeed, running as job.

What actually happened?

Error being thrown due to validatePatternSupported.

Environment

  • CLI Version :
  • Framework Version: 1.71.0
  • Node.js Version:
  • OS :
  • Language (Version):

Other

Sorry, did not actually test this live - just read the code, and it seems obvious.

This is 🐛 Bug Report
@nakedible-p nakedible-p added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 2, 2020
@shivlaks shivlaks mentioned this issue Nov 2, 2020
Merged
@mergify mergify bot closed this as completed in #11188 Nov 2, 2020
mergify bot pushed a commit that referenced this issue Nov 2, 2020
@akiym
fix(stepfunctions-tasks): Athena* APIs have incorrect supported integ…
0f66833 
…ration patterns (#11188)

The changes made by #11045 seem to support `WAIT_FOR_TASK_TOKEN (.waitForTaskToken)` but according to the documentation, only `Request Response` and `Run a job (.sync)` are supported: https://docs.aws.amazon.com/step-functions/latest/dg/connect-athena.html

closes #11246

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 2, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stepfunctions-tasks): Athena* APIs have incorrect supported integration patterns akiym/aws-cdk
1 participant
@nakedible-p