Skip to content

Commit

Permalink
chore: 2.0.0a0 is accidentally identified as 0.0.0 by pack script (#1…
Browse files Browse the repository at this point in the history
…1388)

The pack script defensively checks if there are any artifacts versioned 0.0.0 under the `dist/` directory. Python artifacts are named like so: `aws_cdk.aws_iotanalytics-2.0.0a0-py3-none-any.whl` and since by default grep uses regular expressions, this matches `grep 0.0.0`.

The fix is to use `-F` so that the search string is not treated as regex.
  • Loading branch information
Elad Ben-Israel authored Nov 10, 2020
1 parent d8f4822 commit 9299d4e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pack.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ cp ${changelog_file} ${distdir}/CHANGELOG.md
# defensive: make sure our artifacts don't use the version marker (this means
# that "pack" will always fails when building in a dev environment)
# when we get to 10.0.0, we can fix this...
if find dist/ | grep "${marker}"; then
if find dist/ | grep -F "${marker}"; then
echo "ERROR: build artifacts use the version marker '${marker}' instead of a real version."
echo "This is expected for builds in a development environment but should not happen in CI builds!"
exit 1
Expand Down

0 comments on commit 9299d4e

Please sign in to comment.