update condition and readme

aws · Mar 4, 2024 · 4458a4f · 4458a4f
1 parent 2b61aa1
commit 4458a4f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/aws-cdk-lib/aws-autoscaling/README.md b/packages/aws-cdk-lib/aws-autoscaling/README.md
@@ -542,7 +542,9 @@ property:
 [Custom termination policy](https://docs.aws.amazon.com/autoscaling/ec2/userguide/lambda-custom-termination-policy.html) with lambda
 can be used to determine which instances to terminate based on custom logic.
 The custom termination policy can be specified using `TerminationPolicy.CUSTOM_LAMBDA_FUNCTION`. If this is
-specified, you must also supply a value of lambda arn in the `terminationPolicyCustomLambdaFunctionArn` property.
+specified, you must also supply a value of lambda arn in the `terminationPolicyCustomLambdaFunctionArn` property and
+attach necessary [permission](https://docs.aws.amazon.com/autoscaling/ec2/userguide/lambda-custom-termination-policy.html#lambda-custom-termination-policy-create-function)
+to invoke the lambda function.
 
 If there are multiple termination policies specified,
 custom termination policy with lambda `TerminationPolicy.CUSTOM_LAMBDA_FUNCTION`

diff --git a/packages/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.ts b/packages/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.ts
@@ -1487,12 +1487,11 @@ export class AutoScalingGroup extends AutoScalingGroupBase implements
     if (props.terminationPolicies) {
       props.terminationPolicies.forEach((terminationPolicy, index) => {
         if (terminationPolicy === TerminationPolicy.CUSTOM_LAMBDA_FUNCTION) {
-          if (index != 0) {
+          if (index !== 0) {
             throw new Error('TerminationPolicy.CUSTOM_LAMBDA_FUNCTION must be specified first in the termination policies');
           }
 
-          if (!props.terminationPolicyCustomLambdaFunctionArn ||
-            props.terminationPolicyCustomLambdaFunctionArn.length == 0) {
+          if (!props.terminationPolicyCustomLambdaFunctionArn) {
             throw new Error('terminationPolicyCustomLambdaFunctionArn property must be specified if the TerminationPolicy.CUSTOM_LAMBDA_FUNCTION is used');
           }