Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 0192: update Construct.construct with Construct.node throughout #315

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Apr 21, 2021

Following up on c880239, update the rest of the RFC with the change not
to rename 'node' to 'construct'.


By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license

Following up on c880239, update the rest of the RFC with the change not
to rename 'node' to 'construct'.
@nija-at nija-at requested review from eladb and a team April 21, 2021 08:43
@nija-at nija-at self-assigned this Apr 21, 2021
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-(

The most unfortunate thing in the world

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 79ed467 into master Apr 21, 2021
@mergify mergify bot deleted the nija-at/update-constructs-compat branch April 21, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants