Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk-assets): remove https from endpoint, to work with podman #92

Merged

Conversation

janmeier
Copy link
Contributor

@janmeier janmeier commented Feb 21, 2025

Fixes aws/aws-cdk#16209

Redo of aws/aws-cdk#28926

podman does not allow prefixing the endpoint with https when calling docker login:

fail: docker login --username AWS --password-stdin https://XXX.dkr.ecr.eu-west-1.amazonaws.com exited with error code 125: Error: credentials key has https[s]:// prefix

This PR removes the prefix, which works with both docker and podman


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@janmeier
Copy link
Contributor Author

@kaizencc ping

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (bd02059) to head (065a829).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   84.70%   84.81%   +0.10%     
==========================================
  Files         204      204              
  Lines       35647    35647              
  Branches     4594     4622      +28     
==========================================
+ Hits        30194    30233      +39     
+ Misses       5299     5260      -39     
  Partials      154      154              
Flag Coverage Δ
suite.unit 84.81% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Feb 28, 2025
Merged via the queue into aws:main with commit a30b38d Feb 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cdk-assets): support building Docker images with Podman
6 participants