refactor(cli): require approval is a part of the CliIoHost #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
- Coverage 84.90% 84.70% -0.21%
==========================================
Files 204 204
Lines 35647 35703 +56
Branches 4630 4614 -16
==========================================
- Hits 30266 30241 -25
- Misses 5224 5309 +85
+ Partials 157 153 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kaizencc
commented
Feb 28, 2025
| @@ -246,8 +246,6 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab | |||
|
|
|||
| await migrator.tryMigrateResources(stackCollection, options); | |||
|
|
|||
| const requireApproval = options.requireApproval ?? RequireApproval.NEVER; | |||
There was a problem hiding this comment.
this breaks the behavior of the requireApproval option but i don't have a good way or hooking it up to the requireApproval governed by the CliIoHost -- toolkit.ts only has a concept of an IIoHost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CliIoHostnow governs when to ask for approval or not. This was previously passed into deploy via deployOptions.deployOptions.requireApprovalwas deprecated before, and now it is no longer being used (this may have to be pulled into a different change that removes therequireApprovaloption entirely in a minor version bump of toolkit-lib.CliIoHosthas a property,requireApprovalthat can be set. When therequestResponseAPI is called, we check to see if the message code is a knownrequireApprovalcode and if so, see if the request is necessary or if the default can be used.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license