chore: add git-secrets-scan to repository #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 84.59% 84.66% +0.06%
==========================================
Files 198 198
Lines 35380 35380
Branches 4547 4560 +13
==========================================
+ Hits 29931 29954 +23
+ Misses 5298 5281 -17
+ Partials 151 145 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
iliapolo
reviewed
Feb 26, 2025
.projenrc.ts
Outdated
| ], | ||
| }); | ||
|
|
||
| repoProject.tasks.tryFind('build')?.prependSpawn(gitSecretsScan); |
There was a problem hiding this comment.
Suggested change
| repoProject.tasks.tryFind('build')?.prependSpawn(gitSecretsScan); | |
| repoProject.tasks.tryFind('build')!.prependSpawn(gitSecretsScan); |
So that we fail in case something here changes unexpectedly. Also, probably best to run this AFTER the projen default task because that step can generate code and files.
There was a problem hiding this comment.
now its after default but also after build and eslint, but i think thats fine
Signed-off-by: github-actions <github-actions@github.com>
rix0rrr
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also need to be added to aws-cdk-cli-testing i believe.
git-secrets-scan.shis copied directly from the old repo; i didn't want to also change it to a typescript file. it runs now beforenpx projen build.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license