chore: issue labeler workflow #118
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 84.60% 84.53% -0.08%
==========================================
Files 198 198
Lines 35400 35400
Branches 4569 4546 -23
==========================================
- Hits 29951 29926 -25
- Misses 5295 5326 +31
+ Partials 154 148 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: github-actions <github-actions@github.com>
| parameters?: string; | ||
| affixes?: string; | ||
| areaIsKeyword?: boolean; | ||
| needEnvs?: boolean; |
There was a problem hiding this comment.
How come one jobs needs it and one doesn't? I see its configured on the workflow level in the aws-cdk repo.
There was a problem hiding this comment.
its configured on the workflow level, yes. but it doesn't look like the other job uses those env variables, even if it might have access to it. because of that i think its fine to have the env variables be configured to the job level
There was a problem hiding this comment.
i didn't add the guidance step, which would utilize the workflow level env vars (probs why they put it on the workflow level).
however, projen doesn't currently support workflow-level env variables, so if we were to include the guidance job i'd just add needEnvs: true to that step for now (until we have projen support).
There was a problem hiding this comment.
Followup then - do we not need the guidance step?
|
|
||
| this.workflow.addJob('Triage Issues', triageManagerJob({ | ||
| target: 'issues', | ||
| excludedExpressions: ['CDK CLI Version', 'TypeScript', 'Java', 'Python', 'Go'], |
There was a problem hiding this comment.
Are you sure this works? In the aws-cdk repo this is configured as a string.
There was a problem hiding this comment.
missed a cnversion step :(
| target: 'issues', | ||
| excludedExpressions: ['CDK CLI Version', 'TypeScript', 'Java', 'Python', 'Go'], | ||
| includedLabels: ['needs-triage'], | ||
| excludedLabels: ['p1', 'p2', 'p0', 'effort-small', 'effort-medium', 'effort-large', 'guidance'], |
| uses: aws-github-ops/aws-issue-triage-manager@main | ||
| with: | ||
| target: pull-requests | ||
| areaIsKeyword: true |
There was a problem hiding this comment.
Casing doesn't bother the action? See https://github.com/aws/aws-cdk/blob/main/.github/workflows/issue-label-assign.yml#L36C11-L36C26
There was a problem hiding this comment.
it definitely does, i just missed doing a conversion step that i had planned
Grrr, no projen support: projen/projen#3567. I'm lazy so I just copied and pasted a few from the aws-cdk repo. This is somewhat necessary because it adds the `needs-triage` label automatically, that my other PR will need: #118 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
| - name: Triage Manager | ||
| uses: aws-github-ops/aws-issue-triage-manager@main | ||
| with: | ||
| github-token: ${{ secrets.PROJEN_GITHUB_TOKEN }} |
There was a problem hiding this comment.
https://github.com/aws/aws-cdk/pull/19727/files this doesn't tell me why but it seems it was intentional
Signed-off-by: github-actions <github-actions@github.com>
Attempting to copy and projenify this workflow: https://github.com/aws/aws-cdk/blob/main/.github/workflows/issue-label-assign.yml
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license