Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap): add DeletionPolicy and UpdateReplacePolicy to FileAssetsBucketEncryptionKey #100

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

gracelu0
Copy link
Contributor

  • add DeletionPolicy and UpdateReplacePolicy to FileAssetsBucketEncryptionKey to follow best practice for stateful resources
  • bump bootstrap version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain changed the title chore(bootstrap): add DeletionPolicy and UpdateReplacePolicy to FileAssetsBucketEncryptionKey fix(bootstrap): add DeletionPolicy and UpdateReplacePolicy to FileAssetsBucketEncryptionKey Feb 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (bcef18b) to head (02489c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   84.87%   84.75%   -0.12%     
==========================================
  Files         204      204              
  Lines       35647    35647              
  Branches     4622     4612      -10     
==========================================
- Hits        30256    30214      -42     
- Misses       5234     5280      +46     
+ Partials      157      153       -4     
Flag Coverage Δ
suite.unit 84.75% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gracelu0 gracelu0 force-pushed the update-bootstrap-template branch from fe6ada8 to 81f85f1 Compare February 25, 2025 17:52
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Feb 28, 2025
Merged via the queue into aws:main with commit bd02059 Feb 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants