Skip to content

Commit

Permalink
chore(toolkit-lib): role duration and session tags don't work
Browse files Browse the repository at this point in the history
  • Loading branch information
mrgrain committed Feb 26, 2025
1 parent 130445d commit c3a2d8e
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 18 deletions.
15 changes: 6 additions & 9 deletions .github/workflows/release.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions projenrc/adc-publishing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,8 @@ export class AdcPublishing extends Component {
uses: 'aws-actions/configure-aws-credentials@v4',
with: {
'aws-region': 'us-east-1',
'role-duration-seconds': 14400,
'role-to-assume': '${{ vars.AWS_ROLE_TO_ASSUME_FOR_ACCOUNT }}',
'role-session-name': 'releasing@aws-cdk-cli',
'role-session-name': 'standalone-release@aws-cdk-cli',
'output-credentials': true,
'mask-aws-account-id': true,
},
Expand Down
4 changes: 1 addition & 3 deletions projenrc/record-publishing-timestamp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,8 @@ export class RecordPublishingTimestamp extends Component {
uses: 'aws-actions/configure-aws-credentials@v4',
with: {
'aws-region': 'us-east-1',
'role-duration-seconds': 14400,
'role-to-assume': '${{ vars.AWS_ROLE_TO_ASSUME_FOR_ACCOUNT }}',
'role-session-name': 'releasing@aws-cdk-cli',
'output-credentials': true,
'role-session-name': 'publish-timestamps@aws-cdk-cli',
'mask-aws-account-id': true,
},
},
Expand Down
8 changes: 4 additions & 4 deletions projenrc/s3-docs-publishing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ export class S3DocsPublishing extends Component {
uses: 'aws-actions/configure-aws-credentials@v4',
with: {
'aws-region': 'us-east-1',
'role-duration-seconds': 14400,
'role-to-assume': '${{ vars.AWS_ROLE_TO_ASSUME_FOR_ACCOUNT }}',
'role-session-name': 'releasing@aws-cdk-cli',
'role-session-name': 's3-docs-publishing@aws-cdk-cli',
'mask-aws-account-id': true,
},
},
{
Expand All @@ -82,9 +82,9 @@ export class S3DocsPublishing extends Component {
uses: 'aws-actions/configure-aws-credentials@v4',
with: {
'aws-region': 'us-east-1',
'role-duration-seconds': 14400,
'role-to-assume': this.props.roleToAssume,
'role-session-name': 's3publishing@aws-cdk-cli',
'role-session-name': 's3-docs-publishing@aws-cdk-cli',
'mask-aws-account-id': true,
'role-chaining': true,
},
},
Expand Down

0 comments on commit c3a2d8e

Please sign in to comment.