chore: setup new package to temporarily hold code shared between Tool…

…kit CLI and Library (#170)

Adds the new private package `@aws-cdk/tmp-toolkit-helpers`.

Initially only moves `ToolkitError` into the package to demonstrate its
usage. More PRs will follow to move code from the CLI to this new
package.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>

.projenrc.ts

@@ -156,6 +156,21 @@ function transitiveFeaturesAndFixes(thisPkg: string, depPkgs: string[]) {
   ].join(' '));
 }
 
+/**
+ * Returns all packages that are considered part of the toolkit,
+ * as relative paths from the provided package.
+ */
+function transitiveToolkitPackages(thisPkg: string) {
+  const toolkitPackages = [
+    'aws-cdk',
+    '@aws-cdk/tmp-toolkit-helpers',
+    '@aws-cdk/cloud-assembly-schema',
+    '@aws-cdk/cloudformation-diff',
+  ];
+
+  return transitiveFeaturesAndFixes(thisPkg, toolkitPackages.filter(name => name !== thisPkg));
+}
+
 const repoProject = new yarn.Monorepo({
   projenrcTs: true,
   name: 'aws-cdk-cli',
@@ -668,6 +683,38 @@ cdkAssets.eslint?.addRules({ 'jest/no-export': ['off'] });
 
 //////////////////////////////////////////////////////////////////////
 
+const tmpToolkitHelpers = configureProject(
+  new yarn.TypeScriptWorkspace({
+    ...genericCdkProps({
+      private: true,
+    }),
+    parent: repo,
+    name: '@aws-cdk/tmp-toolkit-helpers',
+    description: 'A temporary package to hold code shared between aws-cdk and @aws-cdk/toolkit-lib',
+    deps: [],
+    devDeps: [
+      cdkBuildTools,
+    ],
+    tsconfig: {
+      compilerOptions: {
+        target: 'es2022',
+        lib: ['es2022', 'esnext.disposable'],
+        module: 'NodeNext',
+        esModuleInterop: false,
+      },
+    },
+  }),
+);
+
+// Prevent imports of private API surface
+tmpToolkitHelpers.package.addField('exports', {
+  '.': './lib/index.js',
+  './package.json': './package.json',
+  './api': './lib/api/index.js',
+});
+
+//////////////////////////////////////////////////////////////////////
+
 let CLI_SDK_VERSION: '2' | '3' = ('3' as any);
 
 const cli = configureProject(
@@ -683,6 +730,7 @@ const cli = configureProject(
       cdkBuildTools,
       yargsGen,
       cliPluginContract,
+      tmpToolkitHelpers,
       '@octokit/rest',
       '@types/archiver',
       '@types/fs-extra@^9',
@@ -826,7 +874,7 @@ const cli = configureProject(
     // Append a specific version string for testing
     nextVersionCommand: 'tsx ../../projenrc/next-version.ts maybeRc',
 
-    releasableCommits: transitiveFeaturesAndFixes('aws-cdk', [cloudAssemblySchema.name, cloudFormationDiff.name]),
+    releasableCommits: transitiveToolkitPackages('aws-cdk'),
   }),
 );
 
@@ -962,7 +1010,7 @@ const cliLib = configureProject(
     devDeps: ['aws-cdk-lib', cli, 'constructs'],
     disableTsconfig: true,
     nextVersionCommand: `tsx ../../../projenrc/next-version.ts copyVersion:../../../${cliPackageJson} append:-alpha.0`,
-    releasableCommits: transitiveFeaturesAndFixes('@aws-cdk/cli-lib-alpha', [cli.name, cloudAssemblySchema.name, cloudFormationDiff.name]),
+    releasableCommits: transitiveToolkitPackages('@aws-cdk/cli-lib-alpha'),
     eslintOptions: {
       dirs: ['lib'],
       ignorePatterns: [
@@ -1118,13 +1166,14 @@ const toolkitLib = configureProject(
       '@types/fs-extra',
       '@types/split2',
       cli,
+      tmpToolkitHelpers,
       'aws-cdk-lib',
       'aws-sdk-client-mock',
       'esbuild',
       'typedoc',
     ],
     // Watch 2 directories at once
-    releasableCommits: transitiveFeaturesAndFixes('@aws-cdk/toolkit-lib', [cli.name, cloudAssemblySchema.name, cloudFormationDiff.name]),
+    releasableCommits: transitiveToolkitPackages('@aws-cdk/toolkit-lib'),
     eslintOptions: {
       dirs: ['lib'],
       ignorePatterns: [
@@ -1170,6 +1219,11 @@ toolkitLib.eslint?.addRules({
       target: './',
       from: '../../aws-cdk',
       message: 'All `aws-cdk` code must be used via lib/api/aws-cdk.ts',
+    },
+    {
+      target: './',
+      from: '../tmp-toolkit-helpers',
+      message: 'All `@aws-cdk/tmp-toolkit-helpers` code must be used via lib/api/shared-*.ts',
     }],
   }],
 });
@@ -1265,7 +1319,7 @@ const cdkCliWrapper = configureProject(
     srcdir: 'lib',
     devDeps: ['aws-cdk-lib', cli, 'constructs', '@aws-cdk/integ-runner'],
     nextVersionCommand: `tsx ../../../projenrc/next-version.ts copyVersion:../../../${cliPackageJson}`,
-    releasableCommits: transitiveFeaturesAndFixes('@aws-cdk/cdk-cli-wrapper', [cli.name, cloudAssemblySchema.name, cloudFormationDiff.name]),
+    releasableCommits: transitiveToolkitPackages('@aws-cdk/cdk-cli-wrapper'),
 
     jestOptions: jestOptionsForProject({
       jestConfig: {
@@ -1295,7 +1349,7 @@ const cdkAliasPackage = configureProject(
     srcdir: 'lib',
     deps: [cli],
     nextVersionCommand: `tsx ../../projenrc/next-version.ts copyVersion:../../${cliPackageJson}`,
-    releasableCommits: transitiveFeaturesAndFixes('cdk', [cli.name, cloudAssemblySchema.name, cloudFormationDiff.name]),
+    releasableCommits: transitiveToolkitPackages('cdk'),
   }),
 );
 void cdkAliasPackage;