-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
revert: feat(cli): cdk rollback (#31407) (#31657)
### Issue # (if applicable) Closes #[31654](aws/aws-cdk#31654). ### Reason for this change This reverts commit d6499d4. ### Description of changes Changes introduced regression in amplify app for nested stacks, reverting it. ### Description of how you validated changes Validated with local build ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
7 changed files
with
10 additions
and
205 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 0 additions & 100 deletions
100
packages/@aws-cdk-testing/cli-integ/resources/cdk-apps/rollback-test-app/app.js
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
packages/@aws-cdk-testing/cli-integ/resources/cdk-apps/rollback-test-app/cdk.json
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
...s/@aws-cdk-testing/cli-integ/resources/cli-regression-patches/v2.161.0/NOTES.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
This patch brings the [fix](https://github.com/aws/aws-cdk/issues/31654) into the regression suite. |
5 changes: 5 additions & 0 deletions
5
packages/@aws-cdk-testing/cli-integ/resources/cli-regression-patches/v2.161.0/skip-tests.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Skipping the test to fix issue https://github.com/aws/aws-cdk/issues/31654. | ||
# cli-integ tests failing for the old tests with the new cli changes for nested stacks. | ||
|
||
test cdk rollback | ||
test cdk rollback --force |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters