Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CNINode integration tests #479

Merged
merged 4 commits into from
Oct 13, 2024
Merged

add CNINode integration tests #479

merged 4 commits into from
Oct 13, 2024

Conversation

sushrk
Copy link
Contributor

@sushrk sushrk commented Sep 27, 2024 •
edited
Loading

Issue #, if available:
Adding CNINode integration tests.

Description of changes:
Tested in dev EKS cluster:

[AfterSuite] 
/home/ravsushm/go/src/github.com/aws/amazon-vpc-resource-controller-k8s/test/integration/cninode/cninode_suite_test.go:46
  STEP: verify CNINode count @ 09/27/24 01:38:34.315
  STEP: checking number of CNINodes match number of nodes in the cluster @ 09/27/24 01:38:34.315
  STEP: checking CNINode list matches node list @ 09/27/24 01:38:34.315
[AfterSuite] PASSED [0.000 seconds]
------------------------------

Ran 2 of 2 Specs in 482.760 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 8m5.151696001s
Test Suite Passed

Commit #2 tests with debug logs:

STEP: adding new node @ 09/27/24 22:52:45.533
ravsushm desiredCap=3  minsize=0  maxsize=3

STEP: restoring ASG minSize & maxSize after test @ 09/27/24 22:53:29.693
ravsushm desiredCap=2  minsize=0  maxsize=1000

STEP: removing existing node @ 09/27/24 22:54:34.055
ravsushm desiredCap=1  minsize=1  maxsize=1000

STEP: restoring ASG minSize & maxSize after test @ 09/27/24 22:55:34.172
ravsushm desiredCap=2  minsize=0  maxsize=1000

[AfterSuite] 
/home/ravsushm/go/src/github.com/aws/amazon-vpc-resource-controller-k8s/test/integration/cninode/cninode_suite_test.go:46
  STEP: verify CNINode count @ 09/27/24 22:56:16.337
  STEP: checking number of CNINodes match number of nodes in the cluster @ 09/27/24 22:56:16.337
  STEP: checking CNINode list matches node list @ 09/27/24 22:56:16.337
[AfterSuite] PASSED [0.000 seconds]
------------------------------

Ran 2 of 2 Specs in 212.707 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 3m35.077490048s
Test Suite Passed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sushrk sushrk requested a review from a team as a code owner September 27, 2024 01:43
haouc
haouc reviewed Sep 27, 2024
View reviewed changes
test/integration/cninode/cninode_test.go Outdated Show resolved Hide resolved
test/framework/resource/k8s/node/wrapper.go Outdated Show resolved Hide resolved
test/integration/cninode/cninode_test.go Outdated Show resolved Hide resolved
test/integration/cninode/cninode_test.go Outdated Show resolved Hide resolved
test/integration/cninode/cninode_test.go Outdated Show resolved Hide resolved
haouc
haouc approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sushrk sushrk merged commit 21961a7 into aws:master Oct 13, 2024
4 checks passed
@sushrk sushrk deleted the cninode-test-master branch October 13, 2024 08:05
yash97 pushed a commit to yash97/amazon-vpc-resource-controller-k8s that referenced this pull request Nov 15, 2024
@sushrk @yash97
add CNINode integration tests (aws#479)
a278536 
* add CNINode integration tests

* address PR comments

* updating log statements

* add retry in VerifyCNINode
yash97 added a commit that referenced this pull request Nov 18, 2024
@yash97 @sushrk
@orsenthil @GnatorX @dependabot @haouc
Updating Release 1.6 branch. (#494)
bd090e0 
* remove global exclusion for G108,G114 and add nosec in code (#404)

* Update controller_auth_proxy_patch.yaml (#405)

Update the reference from gcr.io to registry.k8s.io

>  kube-rbac-proxy is moving to registry.k8s.io/kubebuilder/kube-rbac-proxy (from gcr.io/kubebuilder/kube-rbac-proxy) because GCR is being sunset. We need to update these references.

* Fix log which causes panic (#407)

* Fix log which causes panic

* Consistent key name

* consistent naming

* updating ginkgo and gomega

* Bump github.com/prometheus/common from 0.51.1 to 0.53.0

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.51.1 to 0.53.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.51.1...v0.53.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 (#432)

Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/prometheus/client_model/releases)
- [Commits](prometheus/client_model@v0.6.0...v0.6.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_model
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.19.0 (#431)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.17.2 to 2.19.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.17.2...v2.19.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* QPS and busrt adjustment (#436)

* readme update for events (#453)

* Set controller user-agent to vpc-resource-controller/git-version (#455)

* update user-agent string.

* Use AppName instead of ControllerName.

* Add security group pods scale test in ginkgo (#457)

* Add security group pods scale test in ginkgo

* Add instructions to run scale tests manually

* fix typo in README

* Passing page limit to cach config instead of override. (#452)

* passing page limit to cache config

* adding error log to optimized list watcher

* importing vpc pkg

* pods will requeue for reconcile if nodes are not managed and requested eni (#463)

* pod will requeue for reconcile if nodes are not managed and requested eni

* log statement change

* looping through all container for eni requests

* adding ut for utils function

* add CNINode integration tests (#479)

* add CNINode integration tests

* address PR comments

* updating log statements

* add retry in VerifyCNINode

* Bump go.uber.org/zap from 1.26.0 to 1.27.0 (#480)

Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.26.0...v1.27.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* increasing timeout for few integration test (#486)

* Skipping health check on nodes if EC2 returns throttling errors (#485)

* updating limits.go for supported ec2 instance type #491

* Bump github.com/samber/lo from 1.39.0 to 1.47.0 (#481)

Bumps [github.com/samber/lo](https://github.com/samber/lo) from 1.39.0 to 1.47.0.
- [Release notes](https://github.com/samber/lo/releases)
- [Commits](samber/lo@v1.39.0...v1.47.0)

---
updated-dependencies:
- dependency-name: github.com/samber/lo
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Sushmitha Ravikumar <58063229+sushrk@users.noreply.github.com>
Co-authored-by: Senthil Kumaran <senthilx@amazon.com>
Co-authored-by: Garvin Pang <garvinpang@protonmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hao Zhou <haouc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash97 yash97 yash97 approved these changes

@haouc haouc haouc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushrk @haouc @yash97