Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/lib: bump up aws-k8s-tester to v1.2.2 #978

Merged
merged 1 commit into from
May 19, 2020
Merged

scripts/lib: bump up aws-k8s-tester to v1.2.2 #978

merged 1 commit into from
May 19, 2020

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 18, 2020 •
edited
Loading

ref. aws/aws-k8s-tester@a0c7d18

Otherwise, https://github.com/kubernetes-sigs/aws-alb-ingress-controller/releases/tag/v1.1.7 will fail:

kubebuilder/controller "msg"="Reconciler error" "error"="failed get WAFv2 webACL for load balancer arn:aws:elasticloadbalancing:us-west-2:607362164682:loadbalancer/app/7fbd7e3d-eks2020051714char-ad37/26de385bd4f0a46a: AccessDeniedException: User: arn:aws:sts::607362164682:assumed-role/eks-2020051714-charisma6fxe-role-ng/i-06acdfc5db3ccf8fd is not authorized to perform: wafv2:GetWebACLForResource on resource: arn:aws:wafv2:us-west-2:607362164682:regional/webacl/*\n\tstatus code: 400, request id: 40378ac6-9375-4575-a1e6-1dfb8d2842e4" "controller"="alb-ingress-controller" "request"={"Namespace":"eks-2020051714-charisma6fxe-alb-2048","Name":"alb-2048-ingress"}

https://github.com/kubernetes-sigs/aws-alb-ingress-controller/releases/tag/v1.1.7 says:

New IAM permission is required even no wafv2 annotation is used

@mogren mogren added the testing label May 18, 2020
mogren
mogren approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mogren mogren merged commit 301c2a6 into aws:master May 19, 2020
@gyuho gyuho deleted the tester branch May 19, 2020 01:13
@gyuho gyuho restored the tester branch May 19, 2020 01:13
@gyuho gyuho deleted the tester branch May 19, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogren mogren mogren approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @mogren