Replace debug script with updated script from EKS AMI #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55143b1 to
0593988
Compare
jaypipes
suggested changes
Mar 16, 2020
There was a problem hiding this comment.
@mogren I would much rather we delete the aws-cni-support.sh script from the CNI plugin repo and curl/wget the aws-log-collector.sh script from the eks-ami-builder repo in the Dockerfile, renaming it to aws-cni-support.sh (for backwards compatibility reasons since we have many issues that reference it).
We do this for the CNI base plugins and portmap already here:
Line 190 in a4dc9f5
We should do the same for the aws-log-collector script, IMHO, and remove it from the CNI repo.
539c4f5 to
aeeb94c
Compare
The aws-cni-support.sh has not been kept up to date. Replacing with eks-log-collector.sh from awslabs/amazon-eks-ami Issue: aws#803
42615b3 to
5fa1f14
Compare
nithu0115
added a commit
to nithu0115/amazon-eks-user-guide
that referenced
this pull request
Apr 28, 2020
Updated troubleshooting doc to point to latest EKS log collector script which now is in EKS AMI GitHub repository. Ref: aws/amazon-vpc-cni-k8s#864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #803
The
aws-cni-support.shscript has not been kept up to date. Replacing witheks-log-collector.shfrom awslabs/amazon-eks-ami by @nithu0115.Description of changes:
eks-log-collector.shscript/var/logkube-system_cni-metrics-helperto logs being collected.2>/dev/nullTest output:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.