Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added error handling for GetENIipLimit in AllocIPAddresses func #484

Merged
merged 1 commit into from
May 29, 2019
Merged

Added error handling for GetENIipLimit in AllocIPAddresses func #484

merged 1 commit into from
May 29, 2019

Conversation

Zyqsempai
Copy link
Contributor

@Zyqsempai Zyqsempai commented May 24, 2019 •
edited
Loading

Issue #460

Description of changes: Added error handling for GetENIipLimit in AllocIPAddresses func

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Zyqsempai
Copy link
Contributor Author

@tiffanyfay PTAL

mogren
mogren suggested changes May 24, 2019
View reviewed changes
pkg/awsutils/awsutils.go Outdated Show resolved Hide resolved
@Zyqsempai Zyqsempai force-pushed the 460-add-err-handling-to-GetENIipLimit branch from 2f4d471 to 6d796ab Compare May 29, 2019 08:47
tiffanyfay
tiffanyfay approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@tiffanyfay tiffanyfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiffanyfay tiffanyfay merged commit 8f9d1c2 into aws:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffanyfay tiffanyfay tiffanyfay approved these changes

@mogren mogren mogren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zyqsempai @mogren @tiffanyfay