Allow cross compile on different platform #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
reviewed
Jan 18, 2019
Makefile
Outdated
|
|
||
| docker-build: | ||
| docker run -v $(shell pwd):/usr/src/app/src/github.com/aws/amazon-vpc-cni-k8s \ | ||
| docker run -v $(shell pwd):/usr/src/app/src/github.com/aws/amazon-vpc-cni-k8s:z \ |
There was a problem hiding this comment.
Why do we need the :z suffix for shared bind mounts? Is it just for building on SELinux?
There was a problem hiding this comment.
Exactly, it is just for building on SELinux. I put it as my machine is enabled SELinux (and sorry I forgot to remove it when I sent this PR). I removed it now.
There was a problem hiding this comment.
Seems like it doesn't have any negative effects on non SE systems, so maybe we could have it around. I had no idea it was needed on SELinux, thanks for letting me know 🙃
This patch adds `GOARCH` option to `go build`, so any platform can perform the build for arm64, amd64, or any platform if you like. - Example usage: ``` $ ARCH=amd64 make build-linux GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -o aws-k8s-agent -ldflags "-X main.version=v1.3.0-49-g729fcd41" GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -o aws-cni -ldflags "-X main.version=v1.3.0-49-g729fcd41" ./plugins/routed-eni/ ```
mogren
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
GOARCHoption togo build, so any platform canperform the build for arm64, amd64 and so on from different platform.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.