-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DISABLE_CONTAINER_V6 to disable IPv6 networking in container network namespaces #2499
Conversation
7b766df
to
b02e85a
Compare
b02e85a
to
a88bd9c
Compare
a88bd9c
to
f92eb10
Compare
|
||
Type: Boolean as a String | ||
|
||
Default: `false` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be default true for v6 clusters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, as we don't want to change default behavior. There could be some customers that rely on IPv6 being enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm..it is not needed..we don't want the plugin..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But lets add a line, we shouldn't set this for v6 clusters..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm..
What type of PR is this?
feature
Which issue does this PR fix:
#2483
What does this PR do / Why do we need it:
This PR introduces a new environment variable:
DISABLE_CONTAINER_V6
. When this environment variable is set, thetuning
plugin will be chained in the AWS conflist (/etc/cni/net.d/10-aws.conflist
) and configured to disable IPv6 networking in newly created container network namespaces. This is done to provide a solution to #2483.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Manually verified that conflist is rendered correctly and IPv6 is disabled in newly created container network namespaces. Verified that all integration tests pass following this change.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.