Fix event recorder initialization and add check to log #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
reviewed
Jul 13, 2023
|
New integration test run: https://github.com/aws/amazon-vpc-cni-k8s/actions/runs/5557806856 |
This was referenced Jul 18, 2023
Closed
orsenthil
reviewed
Jul 24, 2023
| @@ -89,3 +94,16 @@ func findMyPod(cachedK8SClient client.Client) (corev1.Pod, error) { | |||
| } | |||
| return pod, err | |||
| } | |||
|
|
|||
| // Functions used for mocking package | |||
| func InitMockEventRecorder() *events.FakeRecorder { | |||
There was a problem hiding this comment.
Post merge review; a mock recorder could be test files as, I hope, we don't use this in real code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#2466
#2448
What does this PR do / Why do we need it:
For #2466 , this PR fixes an issue with creating events when IAM permissions are missing. The EventRecorder object was not being properly initialized. Also, the
EventRecorderpackage is now more modular, so dependent packages can simply calleventrecorder.Get()to get the object. Initialization is left toaws-k8s-agenton startup.For #2448 , this PR fixes a logging issue where a malformed EC2 response (missing
Attachment) was trying to access the missing field in order to log.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Manually verified that integration tests pass. Scheduling runner against this PR.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.