Some cleanups related to #234 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can you add some unit-tests for the multiple CIDRs changes? Or add a issue (technical debts) for it? |
|
I'll add some tests, thanks for taking a look! |
|
@nak3 Anything obvious I've missed? 🙂 |
|
LGTM. Great 👍 |
nak3
reviewed
Jan 31, 2019
| for _, rule := range srcRuleList { | ||
| if n.netLink.RuleDel(&rule); err != nil && !containsNoSuchRule(err) { | ||
| if err := n.netLink.RuleDel(&rule); err != nil && !containsNoSuchRule(err) { |
f81d2b1 to
94dd4c7
Compare
Two small bugfixes in the error handling when deleting rules, otherwise no functional changes.
nckturner
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small bug fixes in the error handling when deleting rules, otherwise no functional changes.
Follow up to #234
Description of changes:
errto verify the result ofnetLink.RuleDel.ipamdActionsInprogressSetandisDuplicateRuleAdd.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.