switch to use state file for IP allocation pool management #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
reviewed
Oct 19, 2022
402a21f to
5a959aa
Compare
jdn5126
reviewed
Oct 20, 2022
jayanthvn
reviewed
Oct 21, 2022
pkg/ipamd/datastore/data_store.go
Outdated
| // Assume that no file == no containers are currently in use, e.g. a fresh reboot just cleared everything out. | ||
| // This is ok, and no-op. | ||
| if os.IsNotExist(err) { | ||
| ds.log.Debugf("backing store don't exists, assuming bootstrap on a new node") |
pkg/ipamd/datastore/data_store.go
Outdated
| @@ -1538,3 +1546,39 @@ func (ds *DataStore) CheckFreeableENIexists() bool { | |||
| } | |||
| return false | |||
| } | |||
|
|
|||
| // NormalizeCheckpointDataByPodVethExistence will normalize checkpoint data by remove allocations that don't have a corresponding pod veth. | |||
jdn5126
pushed a commit
to jdn5126/amazon-vpc-cni-k8s
that referenced
this pull request
Oct 25, 2022
* switch to use state file for IP allocation pool management * add soak test suit for state file * address comments * add missing go.sum entries
This was referenced Oct 28, 2022
This was referenced Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
We need it to remove the CRI socket dependency.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Added a new soak test suit that keep spin up and teardown pods and compare the state file with pods on nodes.
The suit can be executed via:
Will this PR introduce any new dependencies?:
No new dependencies as the file is already written.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
This will break upgrades when upgrade from CNI < 1.7.0, as no state file were wrotten.
I have tested upgrade from CNI 1.10.0, and it works fine
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
Yes, the CRI socket mount is no longer needed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.