Split Calico manifest into two #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2021
68ad552 to
ad34a6e
Compare
|
Thanks @caseydavenport . Can you please update the branch so that I can merge. |
ad34a6e to
0e5d6de
Compare
jayanthvn
approved these changes
Apr 2, 2021
|
@jayanthvn this PR has the corresponding documentation updates: awsdocs/amazon-eks-user-guide#341 |
|
@caseydavenport - awesome, thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
As mentioned in this discussion: #1297 (comment)
The current manifest includes both the Installation CRD as well as an
instance of an Insatllation CR. Since they are both in the same
manfiest, the API server doesn't have time to register the CRD before
the CR is sent, and so the CR is rejected.
They should be in two manfiests, so the user can apply the CRD first and
then apply the CR.
This change will include a corresponding documentation change.
What does this PR do / Why do we need it:
Splits calico.yaml into two so they can be properly ordered.
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.