Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up go lint warnings #1162

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Clean up go lint warnings #1162

merged 1 commit into from
Aug 27, 2020

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Aug 22, 2020

Description of changes:
No code changes, only cleaning up go lint warnings. There are more warnings to clean up, just don't want to put all of them in the same PR.

  • Renamed variables
  • Added comments
  • Filtering out cni.go since it has some ALL_CAPS names by necessity.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren requested a review from jayanthvn August 22, 2020 23:38
@mogren
Copy link
Contributor Author

mogren commented Aug 23, 2020

Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good :)

@jayanthvn jayanthvn merged commit 561190a into aws:master Aug 27, 2020
@mogren mogren deleted the clean-up-go-lint branch September 4, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants