Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use install command instead of cp #1061

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Jun 27, 2020

Description of changes:

When copying in the plugin binaries in our scripts, we should use install instead of cp so that we don't have to rm the files first.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren requested a review from jaypipes June 27, 2020 22:10
Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mogren mogren force-pushed the use-install-not-cp branch 3 times, most recently from 584c1e1 to 86e74c7 Compare June 29, 2020 16:51
@mogren mogren force-pushed the use-install-not-cp branch from 86e74c7 to 0775bdd Compare June 29, 2020 18:57
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mogren mogren merged commit bf9ded3 into aws:master Jun 29, 2020
@mogren mogren deleted the use-install-not-cp branch August 24, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants