This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
ECS now supports cgroups v2 #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ECS now supports cgroups v2 and no longer needs to block the install in this case.
Reference:
aws/containers-roadmap#1535
aws/amazon-ecs-agent#3127
Implementation details
I removed the flow logic that bails if it detects cgroups v2.
Testing
I have been able to successfully run the install script and get a properly running ECS agent in docker on a cgroups v2 debian bullseye docker container.
New tests cover the changes: no
Description for the changelog
Bug - Install script no longer fails on systems using cgroups v2
Licensing
This contribution is under the terms of the Apache 2.0 License: yes