Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Commit

Permalink
add 'none' logging driver ECS Agent's config
Browse files Browse the repository at this point in the history
This commit modifies the `ECS_AVAILABLE_LOGGING_DRIVERS` env var
for the Agent to include `none` logging driver. This compliments
aws/amazon-ecs-agent#1041 PR in the
ECS Agent repository.
  • Loading branch information
aaithal committed Oct 30, 2017
1 parent 088670f commit b08a81d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ecs-init/docker/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func (c *Client) getContainerConfig() *godocker.Config {
"ECS_AGENT_CONFIG_FILE_PATH": config.AgentJSONConfigFile(),
"ECS_UPDATE_DOWNLOAD_DIR": config.CacheDirectory(),
"ECS_UPDATES_ENABLED": "true",
"ECS_AVAILABLE_LOGGING_DRIVERS": `["json-file","syslog","awslogs"]`,
"ECS_AVAILABLE_LOGGING_DRIVERS": `["json-file","syslog","awslogs","none"]`,
"ECS_ENABLE_TASK_IAM_ROLE": "true",
"ECS_ENABLE_TASK_IAM_ROLE_NETWORK_HOST": "true",
}
Expand Down
3 changes: 2 additions & 1 deletion ecs-init/docker/docker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ func validateCommonCreateContainerOptions(opts godocker.CreateContainerOptions,
expectKey("ECS_AGENT_CONFIG_FILE_PATH="+config.AgentJSONConfigFile(), envVariables, t)
expectKey("ECS_UPDATE_DOWNLOAD_DIR="+config.CacheDirectory(), envVariables, t)
expectKey("ECS_UPDATES_ENABLED=true", envVariables, t)
expectKey(`ECS_AVAILABLE_LOGGING_DRIVERS=["json-file","syslog","awslogs"]`, envVariables, t)
expectKey(`ECS_AVAILABLE_LOGGING_DRIVERS=["json-file","syslog","awslogs","none"]`,
envVariables, t)
expectKey("ECS_ENABLE_TASK_IAM_ROLE=true", envVariables, t)
expectKey("ECS_ENABLE_TASK_IAM_ROLE_NETWORK_HOST=true", envVariables, t)
expectKey("ECS_ENABLE_TASK_ENI=true", envVariables, t)
Expand Down

0 comments on commit b08a81d

Please sign in to comment.