Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt go modules #1152

Open
wants to merge 5 commits into
base: mainline
Choose a base branch
from
Open

Adopt go modules #1152

wants to merge 5 commits into from

Conversation

r4v5
Copy link

@r4v5 r4v5 commented Oct 25, 2022

Adopt Go modules for dependencies, removing the existing /ecs-cli/vendor directory and replacing it with a best-effort-possible recreation of what it contained.

Note that dep ensure on current mainline actually generated a bunch of changes that resulted in non-compiling code, so a lot of the commit-based module references are best-effort guesses from what I saw in the vendor dir.

This successfully passes go test when run in an ubuntu 22.04 devcontainer, and the code generation (including the license.go vendor dir auto-creation) still works. I don't have a Windows machine handy to test the functionality of the resulting application, but it's working under Linux and Mac aarch64.

I also created a devcontainer configuration for folks who don't have a Go 1.13 binary hanging around.

The initial intention here was to upgrade the aws-sdk-go version in order to use ARM64 in Fargate and enable container execution (which I have working on a separate branch, though the code doesn't compile under Windows). As a result, I ended up unwinding some of the dependency situation here and figured it'd be useful for other people.

Fixes #994.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing

  • Unit tests passed
  • Integration tests passed
  • [N/A] Unit tests added for new functionality
  • Listed manual checks and their outputs in the comments (example)
  • Link to issue or PR for the integration tests:

Documentation

  • Contacted our doc writer
  • Updated our README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to go modules
1 participant