Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt Go modules for dependencies, removing the existing /ecs-cli/vendor directory and replacing it with a best-effort-possible recreation of what it contained.
Note that
dep ensure
on current mainline actually generated a bunch of changes that resulted in non-compiling code, so a lot of the commit-based module references are best-effort guesses from what I saw in the vendor dir.This successfully passes
go test
when run in an ubuntu 22.04 devcontainer, and the code generation (including the license.go vendor dir auto-creation) still works. I don't have a Windows machine handy to test the functionality of the resulting application, but it's working under Linux and Mac aarch64.I also created a devcontainer configuration for folks who don't have a Go 1.13 binary hanging around.
The initial intention here was to upgrade the aws-sdk-go version in order to use ARM64 in Fargate and enable container execution (which I have working on a separate branch, though the code doesn't compile under Windows). As a result, I ended up unwinding some of the dependency situation here and figured it'd be useful for other people.
Fixes #994.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.