Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge feature/al2022neuron branch to main
Implementation details
al2022neu.pkr.hcl
and modifyal2022.pkr.hcl
build sources to includeal2022neu
scripts/enable-ecs-agent-inferentia-support.sh
to also run whenAMI_TYPE
isal2022neu
. Skip neuron tools installation when it is on AL2022.scripts/enable-ecs-agent-inferentia-support.sh
to install neuron packages on AL2022 base instance and enableINF
on instance.enable-ecs-agent-inferentia-support.sh
script to install possible kernel upgrade (when release distribution is not latest on base AMI).Testing
New tests cover the changes: No
Manual Tests:
Ran
REGION=us-west-2 make al2022neu
and successfully created an private AMI with nameunofficial-amzn2022-ami-ecs-neu-hvm-2022.0.20220831-x86_64-ebs
, idami-0cb05523683ed2eb6
Launched
inf1
/trn1
instances with this AMI and ran a busybox task on this instance.trn1.2xlarge
instance gets 1 neuron devicetrn1.32xlarge
instance gets 16 neuron devicesFunctional test:
--- FAIL: TestContainerAccessIntrospection (21.73s)
. This is a known AL2022 Base AMI issue with route table and not related the specific changes made in this PR.--- FAIL: TestEFS/test-efs-rw-awsvpc (166.33s)
. Error:However, on the affected host, efs url is able to be resolved.
This is likely due to virtual interface issue (ec2-net-utils for AL2022) udev rules configuration incorrectly handles virtual interfaces amazonlinux/amazon-ec2-net-utils#67
--- FAIL: TestEFS/test-efs-iam-awsvpc (166.30s)
. This is the sad case test forTestEFS/test-efs-rw-awsvpc
and we expect a failure whenTestEFS/test-efs-rw-awsvpc
failed.Functional test passed for 20220610 AMI I built before, but test AMI was unfortunately deregistered and the base AL2022 AMI and it's distribution release is also deregistered.
AMI test:
passed.
Description for the changelog
AL2022 Neuron Support
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.