Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use neuron v2 #70

Merged
merged 1 commit into from
Aug 24, 2022
Merged

update to use neuron v2 #70

merged 1 commit into from
Aug 24, 2022

Conversation

Realmonia
Copy link
Contributor

Summary

AWS Neuron team recently release the V2 release of neuron. This PR updates our build script to install latest neuron packages and remove some steps that are no longer required.

Implementation details

Testing

Built an AMI with updated inferentia script. Run functional test suits using this AMI and passed.

New tests cover the changes: n/a

Description for the changelog

Update Neuron build script to use Neuron V2

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sparrc
Copy link
Contributor

sparrc commented Aug 23, 2022

Looks like this installation doesn't match the neuron docs that are linked above in some comments anymore: https://awsdocs-neuron.readthedocs-hosted.com/en/latest/neuron-deploy/tutorials/tutorial-docker-env-setup.html

Not that it needs to block the PR, but can we ask the neuron team to update their docs to recommend the v2 packages?

@Realmonia Realmonia closed this Aug 23, 2022
@Realmonia Realmonia reopened this Aug 23, 2022
@Realmonia
Copy link
Contributor Author

Will do!

@Realmonia Realmonia merged commit 3ca82be into aws:main Aug 24, 2022
@Realmonia Realmonia deleted the neuronV2 branch August 25, 2022 00:22
@sparrc sparrc mentioned this pull request Aug 30, 2022
Realmonia added a commit that referenced this pull request Sep 6, 2022
Realmonia added a commit that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants