Merge feature/al2022 to main #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec00876 to
7663fb5
Compare
fierlion
previously approved these changes
Apr 4, 2022
| ami_type = "al2022arm" | ||
| ami_version = "2022.0.${var.ami_version}" | ||
| } | ||
| } |
There was a problem hiding this comment.
arm is WIP, correct? That's why we don't have everything from al2022.pkr.hcl?
There was a problem hiding this comment.
The build block for both AL2022 and AL2022 ARM are defined in al2022.pkr.hcl, on line 38, instead of redefined in al2022arm.pkr.hcl.
With al2022arm.pkr.hcl and builders defined in al2022.pkr.hcl, users can still run REGION=us-west-2 make al2022arm to build their Al2022 ARM AMIs.
Note: AL2022 ARM is not included in preview, due to amazonlinux/amazon-linux-2023#101.
yinyic
previously approved these changes
Apr 6, 2022
Co-authored-by: Cameron Sparr <sparrc@users.noreply.github.com> Co-authored-by: yinyic <71737798+yinyic@users.noreply.github.com>
…ws#36) * Add most_recent = true to source_ami_filter for all al flavors * Release 20220209 (aws#29) * Rename variables for AL2, update al2022.pkr.hcl and install-workarounds.sh for AL2022 * Update OS name for AL2022 ARM and reorder source AMIs Co-authored-by: Angel Velazquez <angelcar@amazon.com> Co-authored-by: Yash Kulshrestha <YashdalfTheGray@users.noreply.github.com>
* add variables to support local init rpm and pgp key override * fmt * remove pgp key override, let install-additional-packages.sh handle local init install * remove standalone key file
1. Use ssm for AL2022 x86_64 2. Remove aws-logs from workarounds 3. Add the AL2022 distribution release as one of the variables
7663fb5 to
7b00db2
Compare
Realmonia
approved these changes
Apr 6, 2022
yinyic
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge feature/al2022 branch into main branch.
Implementation details
Commits in this PR includes:
Testing
REGION=us-west-2 make al2022New tests cover the changes: no
Description for the changelog
ECS Optimized AL2022 AMI preview
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.