Add include_deprecated=true to all recipes #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During an AMI build, Packer uses the name of the Amazon Linux source AMI defined in release-{ami-family}.auto.pkvars.hcl
It uses the most recent AMI that has the given name. In AL1 recipe, we added included_deprecated=true since the AL1 base AMIs are deprecated.
This commit adds the same flag to all other recipes, so that whenever the base AMI is deprecated, Packer is able to still use it.
mye956
approved these changes
May 30, 2024
chienhanlin
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
include_deprecated=trueto the AMI recipes.During an AMI build, Packer uses the name of the Amazon Linux source AMI we defined in
release-*.auto.pkvars.hcl. It uses the most recent AMI that has the given name. In AL1 recipe, we addedincluded_deprecated=truesince the AL1 base AMIs are deprecated.This PR adds the same flag to all other recipes, so that whenever the base AMI is deprecated, Packer is still able to find and use it. It doesn't change anything functionally, but is more of a safety net - for example, when Amazon Linux deprecates the AL2 base AMI in the future, ECS AMI builds will not be impacted.
Implementation details
Updated all AMI recipes with
include_deprecated=truelike it is in the AL1 recipe today.Testing
New tests cover the changes: no
Description for the changelog
Enhancement: Add
include_deprecated=trueto all AMI recipes.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.