decouple ami_version across ami families #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR decouples ami_version across ami families. This is because we do packer inspect during our AMI builds via
./packer inspect. This gets theami_versionfrom the last readrelease-{al1/al2/al2023}.auto.pkrvars.hclfile. Hence we need to make the ami_version a unique key across the different release configs.Implementation details
rename ami_version to ami_version_{al1/al2/al2023}.
Testing
New tests cover the changes: N/A
Ran ./scripts/check-update.sh to generate the release config files.
Description for the changelog
bugfix: decouple ami_version across ami families
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.