Fix TestExecCommandAgent flakiness on AL1 #4138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestExecCommandAgent
has been quite flaky on AL1. The test starts a/kill
process inside the test container to kill a running ExecCommandAgent process. However, it does not wait for/kill
to finish before checking that ExecCommandAgent has been killed causing the test to fail with the error below.This PR fixes this issue by making the test verify that
/kill
process has finished before verifying that ExecCommandAgent process has been killed.Testing
Reproduced the test failure locally. Ran the test many times after making the change in this PR. It did not fail.
New tests cover the changes: no
Description for the changelog
Bugfix: Fix flakiness of TestExecCommandAgent
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.