Update linked agent version to use built agent #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelcar
approved these changes
Apr 18, 2022
prateekchaudhry
approved these changes
Apr 18, 2022
fierlion
added a commit
to fierlion/amazon-ecs-agent
that referenced
this pull request
May 31, 2022
Note -- windows tests failing due to unrelated volume size change.
fierlion
added a commit
to fierlion/amazon-ecs-agent
that referenced
this pull request
May 31, 2022
Note -- windows tests failing due to unrelated volume size change.
rsheik29
pushed a commit
to rsheik29/amazon-ecs-agent
that referenced
this pull request
Jul 11, 2022
Note -- windows tests failing due to unrelated volume size change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are a few details that I'd missed in the build:
latestImplementation details
I built and tested the
make amazon-linux-rpm-integratedtarget in a fresh ecs-optimized AL2 instance. I am able to start the new agent container and connect to my cluster. I am also able to rundocker history <agent image ID>and see that the ecs rpm's included image is the dockerfree image with a single layer and all expected configuration.New tests cover the changes: no
Description for the changelog
Update linked agent version to use built agent.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.