-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go1.17.2 upgrade #3057
Merged
Merged
Go1.17.2 upgrade #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b93f8b6
to
2039bad
Compare
2039bad
to
cacab14
Compare
cacab14
to
8f69b37
Compare
fenxiong
reviewed
Oct 12, 2021
angelcar
previously approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only outstanding thing is the // +build linux
tag, but lgtm otherwise
fenxiong
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
angelcar
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This upgrades Go version for building ECS agent (both Linux and Windows) to 1.17.2 (latest).
Implementation details
goimports
(// +build
to//go:build
) to fix static check failuresgogenerate
(os "os"
tofs "io/fs"
) to fix static check failuresGO111MODULE=auto
wherever necessary since go mod is the default in the latest versionsHTTP_PROXY
andHTTPS_PROXY
proxy configurations in the/etc/ecs/ecs.config
file. Latest Go includes a security fix to thenet/http package
, and one of the changes is the ProxyFromEnvironment function no longer returns the setting of theHTTP_PROXY
environment variable for https whenHTTPS_PROXY
is unset.To update the internal proxy config after Agent has been initialized, having the http client to check for proxy environment variables for every request is necessary. Used from fenxiong@f231f86
TestSquidProxy
was failing due to the backward breaking change, this set of changes fixes itTesting
New tests cover the changes: yes
Description for the changelog
N/A
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.