Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.53.0 stage #2894

Merged
merged 16 commits into from
Jun 11, 2021
Merged

V1.53.0 stage #2894

merged 16 commits into from
Jun 11, 2021

Conversation

angelcar
Copy link
Contributor

@angelcar angelcar commented Jun 9, 2021

Summary

Stage agent 1.53.0. Changelog:

  • Bug - Revert change that registered Windows ECS Instances using specific OSFamilyType #2859 to address #2881
  • Bug - Fix an edge case that could incorrectly mark a task as STOPPED when Docker crashes while stopping a container #2885

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

amazon-ecs-bot and others added 15 commits May 21, 2021 22:30
boltdb has changed its import path here:
etcd-io/bbolt#211

This change updates the import path for boltdb to make it
consistent with the new import path.
notes:
* dependencies autogenerated by go mod from dep do not always match the previous, so this change explicitly pinned some packages to the specific version that they were at before the migration, and no depedency version is changed as a result;
* there are some changes in the vendor folder despite the dependency version did not change, including: (1) non go source file, for some reason dep pulls more of them than `go mod vendor`; (2) go source file with build tag +ignore, which `go mod vendor` does not pull; (3) file permission change, `go mod vendor` ignores execute permission of file being pulled;
* the go build tools used in our ci such as staticcheck, gocyclo, goimports etc are not migrated to go mod as part of the change, because they are not managed by dep before hence not included in the dep to go mod migration.
* vendor mockgen/model package explicitly. this package is required in order to generate code with mockgen, but it's not automatically vendored with the golang/mock dependency. this commit makes sure the model package is vendored.
* turn off go mod when running version-gen.go. otherwise the build script can fail in container due to no network access.
Revert "Changes to advertise updated OSType while registering ECS Windows instances "
@angelcar angelcar added the staging Trigger staging workflow label Jun 9, 2021
@angelcar angelcar added this to the 1.53.0 milestone Jun 9, 2021
@angelcar angelcar added bot/test and removed staging Trigger staging workflow labels Jun 9, 2021
fenxiong
fenxiong previously approved these changes Jun 9, 2021
@angelcar angelcar added the staging Trigger staging workflow label Jun 9, 2021
@amazon-ecs-bot amazon-ecs-bot merged commit 225bc3a into aws:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Trigger staging workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants