Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Grafana Loki docker log driver. #2514

Closed
wants to merge 1 commit into from

Conversation

cyriltovena
Copy link

Hello this adds support for the Grafana Loki driver in the ecs agent.

Let me know if there is anything else I need to do.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyastella
Copy link
Contributor

thanks for submitting this, we will look into it. I am updating the target branch for this pull request from aws:master to aws:dev to point to the working branch =)

@cyastella cyastella changed the base branch from master to dev July 10, 2020 22:09
@yhlee-aws
Copy link
Contributor

Thank you for the PR. We've investigated and looks like customers can use FireLens to route logs to Grafana Loki, see the Fluent Bit output plugin contributed here. Therefore we've decided against adding explicit support for it in ECS Agent at this time.

@yhlee-aws yhlee-aws closed this Jul 16, 2020
@yhlee-aws
Copy link
Contributor

FYI we have an open feature request for supporting custom log driver here, which should enable customers to use Grafana Loki driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants