Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests in stats package #1031

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Conversation

sharanyad
Copy link
Contributor

@sharanyad sharanyad commented Oct 23, 2017

Summary

Fix flaky unit tests in stats package due to a call in init()
Fixes #1019

Implementation details

Remove unnecessary ecsengine.NewDockerGoClient call in init method of unit tests and add to integ test

Testing

  • Builds on Linux (make release)
  • Builds on Windows (go build -out amazon-ecs-agent.exe ./agent)
  • Unit tests on Linux (make test) pass
  • Unit tests on Windows (go test -timeout=25s ./agent/...) pass
  • Integration tests on Linux (make run-integ-tests) pass
  • Integration tests on Windows (.\scripts\run-integ-tests.ps1) pass
  • Functional tests on Linux (make run-functional-tests) pass
  • Functional tests on Windows (.\scripts\run-functional-tests.ps1) pass

New tests cover the changes:

Description for the changelog

Licensing

This contribution is under the terms of the Apache 2.0 License: yes

remove new godockerclient call in init method of unit tests and add to integ test
@sharanyad sharanyad merged commit acec49a into aws:dev Oct 26, 2017
@samuelkarp samuelkarp added this to the 1.15.0 milestone Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants