chore: Use bytes.Buffer instead of simple string concat #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yimuniao
approved these changes
Aug 28, 2020
| cnt++ | ||
| } | ||
|
|
||
| if cnt < 5 { | ||
| continue | ||
| } | ||
|
|
||
| msg := msgBuf.String() | ||
| e := &LogEvent{ | ||
| msg: msg, |
sky333999
pushed a commit
that referenced
this pull request
Jul 21, 2023
Fix log file monitoring without any metrics collected. Change config-translator to exit with code 0 and delete YAML config if there is no pipeline in the YAML. Change amazon-cloudwatch-agent to start Telegraf framework when YAML does not exist.
dchappa
pushed a commit
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Log message is concatenated using "+" operator, which would always allocate memory upon execution.
Description of changes
Use bytes.Buffer to reduce the memory allocation needed.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Unit tests