launch canary test once a day #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-mateen
commented
Apr 19, 2024
nathalapooja
approved these changes
Apr 19, 2024
lisguo
approved these changes
Apr 19, 2024
|
Maybe as a separate PR but do we also need to bring over the soak test? I see that both soak test and canary are removed from private repo https://github.com/aws/private-amazon-cloudwatch-agent-staging/pull/696/files |
zhihonl
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We previously had a canary test against a private S3 bucket.
We stopped updating that private S3 bucket.
We should have a canary test that exercises the same download/install mechanisms that users use.
(aka post release testing)
Description of changes
Related change - aws/amazon-cloudwatch-agent-test#404
The github workflow runs on a CRON schedule - once a day at 15:00 UTC.
The workflow just launches a long lived EC2 instance which has a local CRON job that runs a Go test.
The Go test will download, install, configure, and start the agent.
The test reports a few custom metrics.
And the agent obviously reports some metrics based on the simple config it is given.
After this change is merged I will add alarms on these various metrics in our test account.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Refer to the linked PR.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint