Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageMaker LLM Falcon 40b fails to start #635

Closed
6 tasks done
pdifranc opened this issue Oct 1, 2023 · 3 comments
Closed
6 tasks done

SageMaker LLM Falcon 40b fails to start #635

pdifranc opened this issue Oct 1, 2023 · 3 comments
Assignees
Labels

Comments

@pdifranc
Copy link

pdifranc commented Oct 1, 2023

Describe the bug
When enabling the SageMaker endpoint with Falcon 40b, the endpoint fails to start

> #033[2m2023-10-01T14:42:56.994807Z#033[0m #033[31mERROR#033[0m #033[1mshard-manager#033[0m: #033[2mtext_generation_launcher#033[0m#033[2m:#033[0m Error when initializing model
> File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 124, in serve_inner
    model = get_model(model_id, revision, sharded, quantize, trust_remote_code)
  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/__init__.py", line 286, in get_model
    raise ValueError("sharded is not supported for AutoModel")

To Reproduce
just deploy the stack and enable LLM on a ml.g5.12xlarge instance

Expected behavior
The deployment is successful

Please complete the following information about the solution:

  • Version: [v5.4.2]

To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "(SO0189) QnABot [...] [v5.4.2]".

  • Region: eu-west-1
  • Was the solution modified from the version published on this repository? no
  • If the answer to the previous question was yes, are the changes available on GitHub?
  • Have you checked your service quotas for the services this solution uses? yes
  • Were there any errors in the CloudWatch Logs? yes

Screenshots
logs specified above

Additional context
Add any other context about the problem here.

@pdifranc pdifranc added the bug label Oct 1, 2023
@kroeter
Copy link

kroeter commented Oct 1, 2023

Hey pdifranc - thank you for the note. We have an open ticket with the SageMaker team to resolve. Will keep you updated on progress.

@rstrahan
Copy link
Contributor

rstrahan commented Oct 1, 2023 via email

@marcburnie marcburnie self-assigned this Oct 2, 2023
fhoueto-amz added a commit that referenced this issue Oct 3, 2023
## [5.4.2] - 2023-09-30
### Added
- Self-hosting web fonts. Font files used by QnABot UI are now served from QnABot server instead of using third party font provider.

### Updated

- Security patches for npm and pip packages
- Lambda runtimes updated to NodeJS 18 for CFN Bootstrap Lambda
- SonarQube Quality Gates fix
- Bluebird Promise Migration (Partial)
    - Utilize native promises supported in JavaScript
    - Full migration planned for v5.5.0. Done as a prerequisite for JavaScript SDK v3 migration planned for v6.0.0
    - Remaining changes to be implemented in v5.5.0 include ./website, ./cfn, & ./templates

### Fixed
- Fixed request signing issue when using Custom domain ([issue #605](#605))
- Fixed Sagemaker LLM deployment ([issue #635](#635))
- Fixed voice integration with LLM response
- Fixed unsupported SSML tags
- Fixed Kendra API retrieval bug
@marcburnie
Copy link
Member

Thanks @pdifranc for reporting the issue. This problem affects v5.4.0, v5.4.1, and the version of v5.4.2 that you are using.

To summarize the issue, a recent commit on the model repo (https://huggingface.co/tiiuae/falcon-40b-instruct/commit/ecb78d97ac356d098e79f0db222c9ce7c5d9ee5f) has broken compatibility with the model image used in QnABot. This problem has been resolved in the v5.4.2 release by specifying an earlier commit from the model repo (see https://github.com/aws-solutions/qnabot-on-aws/blob/main/templates/sagemaker-qa-summarize-llm/index.js#L53).

If you are deploying from this repo, please pull and deploy the v5.4.2 tag/branch: https://github.com/aws-solutions/qnabot-on-aws/releases/tag/v5.4.2. If you deployed from the Implementation Guide, please pull and deploy the latest template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants